Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SNOW-1527902]: Add support for limit parameter in fillna. #1891

Merged
merged 3 commits into from
Jul 10, 2024
Merged

[SNOW-1527902]: Add support for limit parameter in fillna. #1891

merged 3 commits into from
Jul 10, 2024

Conversation

sfc-gh-rdurrani
Copy link
Contributor

@sfc-gh-rdurrani sfc-gh-rdurrani commented Jul 9, 2024 •
edited
Loading

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1527902

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.

  3. Please describe how your code solves the related issue.

Add support for the limit parameter in fillna.

@sfc-gh-rdurrani sfc-gh-rdurrani requested a review from a team as a code owner July 9, 2024 23:44
sfc-gh-helmeleegy
sfc-gh-helmeleegy approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-helmeleegy sfc-gh-helmeleegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks! But before merging, can you please add the examples referring to limit back to the doc strings?

@sfc-gh-rdurrani
Copy link
Contributor Author

LGTM. Thanks! But before merging, can you please add the examples referring to limit back to the doc strings?

Good catch, thank you! Will add back now!

@sfc-gh-rdurrani sfc-gh-rdurrani enabled auto-merge (squash) July 10, 2024 22:15
sfc-gh-evandenberg
sfc-gh-evandenberg approved these changes Jul 10, 2024
View reviewed changes
Copy link
Collaborator

@sfc-gh-evandenberg sfc-gh-evandenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sfc-gh-vbudati
sfc-gh-vbudati reviewed Jul 10, 2024
View reviewed changes
docs/source/modin/supported/series_supported.rst
@@ -186,7 +186,9 @@ Methods
+-----------------------------+---------------------------------+----------------------------------+----------------------------------------------------+
| ``factorize`` | N | | |
+-----------------------------+---------------------------------+----------------------------------+----------------------------------------------------+
| ``ffill`` | P | | ``N`` if parameter ``limit`` is set |
| ``ffill`` | P | | ``N`` if parameter ``downcast`` is set. ``limit`` |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Over here and in the other rst file - add the downcast parameter to the "Missing parameters" column

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this PR got merged, I'll go ahead and add it to this PR: #1893 if that works?

@sfc-gh-rdurrani sfc-gh-rdurrani merged commit be50b7b into main Jul 10, 2024
33 of 35 checks passed
@sfc-gh-rdurrani sfc-gh-rdurrani deleted the rdurrani-SNOW-1527902 branch July 10, 2024 23:59
@github-actions github-actions bot locked and limited conversation to collaborators Jul 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-vbudati sfc-gh-vbudati sfc-gh-vbudati left review comments

@sfc-gh-helmeleegy sfc-gh-helmeleegy sfc-gh-helmeleegy approved these changes

@sfc-gh-evandenberg sfc-gh-evandenberg sfc-gh-evandenberg approved these changes

@sfc-gh-jkew sfc-gh-jkew Awaiting requested review from sfc-gh-jkew sfc-gh-jkew is a code owner automatically assigned from snowflakedb/snowpark-pandas-api

Assignees
No one assigned
Labels
snowpark-pandas
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-rdurrani @sfc-gh-evandenberg @sfc-gh-vbudati @sfc-gh-helmeleegy